wgpu_core/lock/

rank.rs

//! Ranks for `wgpu-core` locks, restricting acquisition order.
//!
//! See [`LockRank`].

/// The rank of a lock.
///
/// Each [`Mutex`], [`RwLock`], and [`SnatchLock`] in `wgpu-core` has been
/// assigned a *rank*: a node in the DAG defined at the bottom of
/// `wgpu-core/src/lock/rank.rs`. The rank of the most recently
/// acquired lock you are still holding determines which locks you may
/// attempt to acquire next.
///
/// When you create a lock in `wgpu-core`, you must specify its rank
/// by passing in a [`LockRank`] value. This module declares a
/// pre-defined set of ranks to cover everything in `wgpu-core`, named
/// after the type in which they occur, and the name of the type's
/// field that is a lock. For example, [`CommandBuffer::data`] is a
/// `Mutex`, and its rank here is the constant
/// [`COMMAND_BUFFER_DATA`].
///
/// Building with `RUSTFLAGS="--cfg wgpu_validate_locks"`, replaces the
/// lock implementation in `lock::vanilla` with in `lock::ranked`, which
/// checks that the observed sequences of lock acquisition respect the
/// ordering defined here.
///
/// TODO(<https://github.com/gfx-rs/wgpu/issues/5572>): Resolve invalid
/// acquisitions of DEVICE_COMMAND_INDICES followed by COMMAND_BUFFER_DATA.
///
/// [`Mutex`]: parking_lot::Mutex
/// [`RwLock`]: parking_lot::RwLock
/// [`SnatchLock`]: crate::snatch::SnatchLock
/// [`CommandBuffer::data`]: crate::command::CommandBuffer::data
#[derive(Debug, Copy, Clone)]
pub struct LockRank {
    /// The bit representing this lock.
    ///
    /// There should only be a single bit set in this value.
    pub(super) bit: LockRankSet,

    /// A bitmask of permitted successor ranks.
    ///
    /// If `rank` is the rank of the most recently acquired lock we
    /// are still holding, then `rank.followers` is the mask of
    /// locks we are allowed to acquire next.
    ///
    /// The `define_lock_ranks!` macro ensures that there are no
    /// cycles in the graph of lock ranks and their followers.
    pub(super) followers: LockRankSet,
}

/// Define a set of lock ranks, and each rank's permitted successors.
macro_rules! define_lock_ranks {
    {
        $(
            $( #[ $attr:meta ] )*
            rank $name:ident $member:literal followed by { $( $follower:ident ),* $(,)? }
        )*
    } => {
        // An enum that assigns a unique number to each rank.
        #[allow(non_camel_case_types, clippy::upper_case_acronyms)]
        enum LockRankNumber { $( $name, )* }

        bitflags::bitflags! {
            #[derive(Debug, Copy, Clone, Eq, PartialEq)]
            /// A bitflags type representing a set of lock ranks.
            pub struct LockRankSet: u64 {
                $(
                    const $name = 1 << (LockRankNumber:: $name as u64);
                )*
            }
        }

        impl LockRankSet {
            pub fn member_name(self) -> &'static str {
                match self {
                    $(
                        LockRankSet:: $name => $member,
                    )*
                    _ => "<unrecognized LockRankSet bit>",
                }
            }

            #[cfg_attr(not(feature = "observe_locks"), allow(dead_code))]
            pub fn const_name(self) -> &'static str {
                match self {
                    $(
                        LockRankSet:: $name => stringify!($name),
                    )*
                    _ => "<unrecognized LockRankSet bit>",
                }
            }
        }

        $(
            // If there is any cycle in the ranking, the initializers
            // for `followers` will be cyclic, and rustc will give us
            // an error message explaining the cycle.
            $( #[ $attr ] )*
            pub const $name: LockRank = LockRank {
                bit: LockRankSet:: $name,
                followers: LockRankSet::empty() $( .union($follower.bit) )*,
            };
        )*
    }
}

define_lock_ranks! {
    // Non-leaf ranks, in topological order.
    rank COMMAND_BUFFER_DATA "CommandBuffer::data" followed by {
        DEVICE_SNATCHABLE_LOCK,
        BUFFER_MAP_STATE,
        COMMAND_ALLOCATOR_FREE_ENCODERS,
        BUFFER_POOL,
        DEVICE_TRACE,
        DEVICE_USAGE_SCOPES,
        REGISTRY_STORAGE,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }
    rank DEVICE_SNATCHABLE_LOCK "Device::snatchable_lock" followed by {
        BUFFER_MAP_STATE,
        DEVICE_COMMAND_INDICES,
        QUEUE_PENDING_WRITES,
        TEXTURE_INITIALIZATION_STATUS,
        QUEUE_LIFE_TRACKER,
        BLAS_COMPACTION_STATE,
        BUFFER_BIND_GROUPS,
        BUFFER_INITIALIZATION_STATUS,
        BUFFER_POOL,
        DEVICE_TRACE,
        DEVICE_USAGE_SCOPES,
        REGISTRY_STORAGE,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
        TEXTURE_BIND_GROUPS,
        TEXTURE_CLEAR_MODE,
        TEXTURE_VIEWS,
        QUERY_SET_INITIALIZED_SLOTS,
        // Uncomment this to see an interesting cycle.
        // COMMAND_BUFFER_DATA,
    }
    rank DEVICE_COMMAND_INDICES "Device::command_indices" followed by {
        BUFFER_POOL,
        QUEUE_PENDING_WRITES,
        QUEUE_LIFE_TRACKER,
        COMMAND_ALLOCATOR_FREE_ENCODERS,
        DEVICE_DEFERRED_DESTROY,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }
    rank QUEUE_PENDING_WRITES "Queue::pending_writes" followed by {
        BUFFER_MAP_STATE,
        DEVICE_TRACKERS,
        COMMAND_ALLOCATOR_FREE_ENCODERS,
        BUFFER_INITIALIZATION_STATUS,
        TEXTURE_INITIALIZATION_STATUS,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }
    rank TEXTURE_INITIALIZATION_STATUS "Texture::initialization_status" followed by {
        DEVICE_TRACKERS,
    }
    rank DEVICE_TRACKERS "Device::trackers" followed by {
        TEXTURE_CLEAR_MODE,
    }
    rank QUEUE_LIFE_TRACKER "Queue::life_tracker" followed by {
        BUFFER_MAP_STATE,
        BUFFER_INITIALIZATION_STATUS,
        BUFFER_POOL,
        COMMAND_ALLOCATOR_FREE_ENCODERS,
        DEVICE_DEFERRED_DESTROY,
        DEVICE_TRACE,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }
    rank BUFFER_MAP_STATE "Buffer::map_state" followed by {
        DEVICE_TRACE,
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }
    rank COMMAND_ALLOCATOR_FREE_ENCODERS "CommandAllocator::free_encoders" followed by {
        SHARED_TRACKER_INDEX_ALLOCATOR_INNER,
    }

    // Leaf ranks reachable from the graph above, alphabetical.
    rank BLAS_COMPACTION_STATE "Blas::compaction_state" followed by { }
    rank BUFFER_BIND_GROUPS "Buffer::bind_groups" followed by { }
    rank BUFFER_INITIALIZATION_STATUS "Buffer::initialization_status" followed by { }
    rank BUFFER_POOL "BufferPool::buffers" followed by { }
    rank DEVICE_DEFERRED_DESTROY "Device::deferred_destroy" followed by { }
    rank DEVICE_TRACE "Device::trace" followed by { }
    rank DEVICE_USAGE_SCOPES "Device::usage_scopes" followed by { }
    rank REGISTRY_STORAGE "Registry::storage" followed by { }
    rank SHARED_TRACKER_INDEX_ALLOCATOR_INNER "SharedTrackerIndexAllocator::inner" followed by { }
    rank QUERY_SET_INITIALIZED_SLOTS "QuerySet::initialized_slots" followed by { }
    rank TEXTURE_BIND_GROUPS "Texture::bind_groups" followed by { }
    rank TEXTURE_CLEAR_MODE "Texture::clear_mode" followed by { }
    rank TEXTURE_VIEWS "Texture::views" followed by { }

    // Ranks not connected to the graph, alphabetical.
    rank BLAS_BUILT_INDEX "Blas::built_index" followed by { }
    rank DEVICE_LOST_CLOSURE "Device::device_lost_closure" followed by { }
    rank IDENTITY_MANAGER_VALUES "IdentityManager::values" followed by { }
    rank RESOURCE_POOL_INNER "ResourcePool::inner" followed by { }
    rank SURFACE_PRESENTATION "Surface::presentation" followed by { }
    rank TLAS_BUILT_INDEX "Tlas::built_index" followed by { }
    rank TLAS_DEPENDENCIES "Tlas::dependencies" followed by { }

    #[cfg(test)]
    rank PAWN "pawn" followed by { ROOK, BISHOP }
    #[cfg(test)]
    rank ROOK "rook" followed by { KNIGHT }
    #[cfg(test)]
    rank KNIGHT "knight" followed by { }
    #[cfg(test)]
    rank BISHOP "bishop" followed by { }
}